-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(types): cast from number
to string
explicitly
#5342
Conversation
- fix `TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.` error
Publish flamegraph to https://98a38e86ecc0f039a07dece2e29f0dcaaffc98fa-16-hexo.surge.sh/flamegraph.html |
Pull Request Test Coverage Report for Build 6709541831
💛 - Coveralls |
what circumstances does this problem occur. I can't reproduce it. |
Checkout
|
I try node@20.5.1 and still can't reproduce. tsc 4.6.4
$ npx tsc -v
Version 4.6.4
$ npm run build
> hexo@7.0.0 build
> tsc -b
lib/box/index.ts:60:3 - error TS4055: Return type of public method from exported class has or is using private name '_File'.
60 _createFileClass() {
~~~~~~~~~~~~~~~~
lib/hexo/index.ts:463:3 - error TS4055: Return type of public method from exported class has or is using private name 'Locals'.
463 _generateLocals() {
~~~~~~~~~~~~~~~
lib/hexo/router.ts:17:27 - error TS4020: 'extends' clause of exported class 'RouteStream' has or is using private name 'Readable'.
17 class RouteStream extends Readable {
~~~~~~~~
Found 3 errors. |
v4.6.4 found 3 errors |
Can we specify which version of |
I think we can follow the latest version |
What does it do?
fix
TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.
error. I ignore them with@ts-ignore
when I publishedv7.0.0
.Screenshots
N/A
Pull request tasks