Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correct the IP address displayed by server #755

Merged
merged 1 commit into from
Jul 30, 2014

Conversation

mrjohannchang
Copy link
Contributor

Server shows wrong IP address it listens to before. It shows 0.0.0.0 while it is listening to localhost and vice versa. Also, we don't need another var only for displaying, just getting the var what server really got is enough.

Server shows wrong IP address it listens to before. It shows 0.0.0.0
while it is listening to localhost and vice versa. Also, we don't need
another var only for displaying, just getting the var what server really
got is enough.
@tommy351
Copy link
Member

Sorry not mention in the pull request #754. Please also modify the default configuration of server_ip in lib/loaders/config.js. You can push your commits to this pull request directly.

@mrjohannchang
Copy link
Contributor Author

I've uploaded a new commit for #754, please check it.

@tommy351
Copy link
Member

OK. I'll try to merge your commit manually.

tommy351 added a commit that referenced this pull request Jul 30, 2014
Correct the IP address displayed by server
@tommy351 tommy351 merged commit 1545874 into hexojs:master Jul 30, 2014
@mrjohannchang
Copy link
Contributor Author

I don't mean to bother you but can you reopen #754 and then merge the new commit from that PR?

@tommy351
Copy link
Member

No. I can't.

@mrjohannchang mrjohannchang deleted the pr-correctness-bind-ip branch May 19, 2021 00:47
@mrjohannchang mrjohannchang restored the pr-correctness-bind-ip branch May 19, 2021 00:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants