Allow for no timestamp being appended #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation states that `false` is a valid value for the `dateFormat` global config param. That usually suggests that passing `false` means "do not add this field" but in this case, the code said otherwise, it meant: "use ISO". Since most loggers nowadays (including `console.log`!) already add a timestamp to the log line, there has to be a way to opt-out of this field, to avoid repetition. Example: **Before:** ``` 2020-08-11T21:25:35.736Z 90142447-1486-1b56-34e1-68e1b1439670 INFO [Response] 2020-08-11T21:25:35+0000 https://example.com/api/meters/123 GET ``` **After:** ``` 2020-08-11T21:25:35.736Z 90142447-1486-1b56-34e1-68e1b1439670 INFO [Response] https://example.com/api/meters/123 GET ```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that
falseis a valid value for thedateFormatglobal config param. That usually suggests that passingfalsemeans "do not add this field" but in this case, the code said otherwise, it meant: "use ISO".Since most loggers nowadays (including
console.log!) already add a timestamp to the log line, there has to be a way to opt-out of this field, to avoid repetition.Example:
Before:
After: