Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add log config into error logger with a promise #73

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Add log config into error logger with a promise #73

merged 1 commit into from
Nov 13, 2020

Conversation

gurisko
Copy link
Contributor

@gurisko gurisko commented Nov 2, 2020

Fixes #72

Reasoning:
This is the only method that is exported in index.ts from the file. Every other loggers support config as the second argument.

hg-pyun
hg-pyun approved these changes Nov 2, 2020
View reviewed changes
Copy link
Owner

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, Good point. Thank you!

@hg-pyun hg-pyun mentioned this pull request Nov 2, 2020
Closed
8 tasks
@hg-pyun hg-pyun merged commit 823f9b7 into hg-pyun:master Nov 13, 2020
@gurisko
Copy link
Contributor Author

gurisko commented Nov 13, 2020

Thank you @hg-pyun for merging this!

@gurisko gurisko deleted the fixes-72 branch November 17, 2020 10:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees

@gurisko gurisko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

errorLogger to accept ErrorLogConfig
2 participants
@gurisko @hg-pyun