This repository was archived by the owner on Jun 1, 2024. It is now read-only.
Add aliasses for noreturn functions with nothing #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The noreturn variants affect the typechecker in interesting ways.
This is often sur# and breaks tests using expect($it)->toThrow().
I have seen the following workarounds in the wild.
```
if ('always true') {
self::markTestSkipped('skipping');
}
(): void ==> {
self::markTestSkipped('skipping');
}();
```
facebook-github-bot
added
the
CLA Signed
The word choice "bogus" was quite poor. Typechecking in unreachable code may have false positives. Baseless is more formal and bogus sounds a bit like an insult.
|
LGTM |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The noreturn variants affect the typechecker in interesting ways.
This is often sur# and breaks tests using expect($it)->toThrow().
I have seen the following workarounds in the wild.