Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Str\split and Str\join should take the thing being operated on first #3

Closed
fredemmott opened this issue Jun 28, 2017 · 1 comment
Closed

Str\split and Str\join should take the thing being operated on first #3

fredemmott opened this issue Jun 28, 2017 · 1 comment
Assignees
@kmeht
Labels
volatile API

Comments

@fredemmott
Copy link
Contributor

No description provided.

@fredemmott
Copy link
Contributor Author

Internal: t17219441

@fredemmott fredemmott mentioned this issue Aug 31, 2017
Closed
@kmeht kmeht self-assigned this Sep 11, 2017
@fredemmott fredemmott assigned kmeht and unassigned kmeht Sep 11, 2017
facebook-github-bot pushed a commit that referenced this issue Sep 22, 2017
@kmeht @facebook-github-bot
Str\{join, split}_args_switched
bdf9fc9 
Summary:
This is our last chance to fix these functions before the HSL is marked stable.

refs #3

Reviewed By: fredemmott

Differential Revision: D5892247

fbshipit-source-id: 071248908f3c8aa127e2fd16178ee97f6f50cf8f
facebook-github-bot pushed a commit that referenced this issue Sep 29, 2017
@kmeht @facebook-github-bot
Use Str\join_args_switched in generate-docs
5a1d5f7 
Summary: See #3

Reviewed By: fredemmott

Differential Revision: D5946094

fbshipit-source-id: 6f1a57f710e4d64b805a96de98a5c9da29c916b1
facebook-github-bot pushed a commit that referenced this issue Oct 5, 2017
@kmeht @facebook-github-bot
Swap Str\{join, split} arguments
9346487 
Summary:
Internal callsites have been moved over to the `args_switched` variants.

See #3.

Reviewed By: fredemmott

Differential Revision: D5960943

fbshipit-source-id: 8bcfa872530b0d37bb0815c23bf996e9435a519a
facebook-github-bot pushed a commit that referenced this issue Oct 6, 2017
@kmeht @facebook-github-bot
Remove Str\split_args_switched
9189d09 
Summary: See #3.

Reviewed By: fredemmott

Differential Revision: D5993148

fbshipit-source-id: 3f0bfdd65e2e80290beec84ee922ea6e2f7b58a2
facebook-github-bot pushed a commit that referenced this issue Oct 6, 2017
@kmeht @facebook-github-bot
Str\{join_args_switched -> join}
18db5a9 
Summary: See #3.

Reviewed By: DavidSnider

Differential Revision: D5994725

fbshipit-source-id: e54dc4533615bc7fa2850eb1a514e8314e6e40a3
@kmeht kmeht closed this as completed Oct 8, 2017
@savil savil mentioned this issue Apr 5, 2018
Open
@lowfundaquizzer lowfundaquizzer mentioned this issue Aug 20, 2019
Closed
facebook-github-bot pushed a commit that referenced this issue Jul 10, 2024
@facebook-github-bot
Fix Vec\intersect() generator bug
ed8f8b0 
Summary:
I ran across this testing something. `Vec\intersect()` doesn't work when the first parameter is a generator:

```
fbdbg> $s = Streams::filter(Vec\range(1, 10), $x ==> true)
fbdbg> =Vec\intersect($s, vec[5])
Hit a php exception : exception 'Exception' with message 'Generator is already finished' in /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php:168
Stack trace:
#0 (): Generator->rewind()
#1 (): HH\Lib\Vec\filter()
#2 /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php(168): HH\Lib\Vec\intersect()
#3 (1): FlibSL\Vec\intersect()
#4 (1): include()
#5 (): include()
#6 {main}
Hit a php exception : exception 'Exception' with message 'Generator is already finished' in /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php:168
Stack trace:
#0 (): Generator->rewind()
#1 (): HH\Lib\Vec\filter()
#2 /data/sandcastle/boxes/www/flib/core/hack/lib/hsl_generated/vec/select.php(168): HH\Lib\Vec\intersect()
#3 (1): FlibSL\Vec\intersect()
#4 (1): include()
#5 (): include()
#6 {main}
Failed to evaluate expression
```

The cause is that it iterates over the generator again after `Keyset\intersect()` has been called.

https://www.internalfb.com/code/fbsource/[4e26eed969060508bfbd3c4f675e018ca367c556]/fbcode/hphp/hsl/src/vec/select.php?lines=186-189

Reviewed By: viratyosin

Differential Revision: D59356423

fbshipit-source-id: 8ec1b5d00183d09606728c97d61bf30a26bfdf1c
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kmeht kmeht

Labels
volatile API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fredemmott @kmeht