Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

使用Engines简单实现redis上线,仅作为接入样例 #101

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Apr 3, 2019

test case 待补充

  • RedisEngine 新增execute_check、execute_workflow方法实现
  • 检测不做处理,全部通过
  • 执行有正常结束和异常终止状态
  • 工单类型全部为标记为其他

@hhyo hhyo requested a review from LeoQuote April 3, 2019 14:29
@hhyo hhyo added the enhancement New feature or request label Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #101 into master will increase coverage by 0.4%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #101     +/-   ##
=========================================
+ Coverage   68.27%   68.67%   +0.4%     
=========================================
  Files          61       61             
  Lines        6105     6146     +41     
=========================================
+ Hits         4168     4221     +53     
+ Misses       1937     1925     -12
Impacted Files Coverage Δ
sql/engines/tests.py 100% <100%> (ø) ⬆️
sql/models.py 95.62% <100%> (ø) ⬆️
sql/sql_workflow.py 57.26% <100%> (ø) ⬆️
sql/engines/redis.py 85.71% <80%> (-2.62%) ⬇️
sql/engines/models.py 65.97% <0%> (+17.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b335b7c...ef7bcdb. Read the comment docs.

@hhyo hhyo changed the title 使用Engines简单实现redis上线,检测未做处理,仅作为接入样例 使用Engines简单实现redis上线,仅作为接入样例 Apr 3, 2019
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就是单元测试暂时没跟上。
如果能前端能再少改一些就好了,比如label能不能用choices进行渲染?

(其实感觉也没太大必要,数据库类型总共没几个

@hhyo
Copy link
Owner Author

hhyo commented Apr 4, 2019

第一次接入,修改的前端比较多,后续就只要加一行就好了

@hhyo hhyo merged commit cef6873 into master Apr 5, 2019
@hhyo hhyo deleted the redis branch May 6, 2019 12:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants