Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

脱敏解析替换为goInception,移除Inception依赖 #1483

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Apr 30, 2022

  1. 完全移除Inception的依赖和配置项
  2. 脱敏解析替换为goInception,goInception已经直接解析出select list,移除相关冗余代码
  3. 经测试已兼容大部分的语法,包括Inception无法解析的子查询、函数表达式等
  4. goInception版本需要>=v1.2.5-29

感谢@unknowissue@hanchuanchuan

相关issue:#1307

相关文档:
hanchuanchuan/goInception#355
https://hanchuanchuan.github.io/goInception/tree.html#expression-type

@hhyo
Copy link
Owner Author

hhyo commented Apr 30, 2022

@unknowissue 有时间可以给看看

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #1483 (43f5d61) into master (e66c77f) will increase coverage by 1.71%.
The diff coverage is 86.88%.

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
+ Coverage   75.30%   77.01%   +1.71%     
==========================================
  Files          91       89       -2     
  Lines       14455    14003     -452     
==========================================
- Hits        10885    10785     -100     
+ Misses       3570     3218     -352     
Impacted Files Coverage Δ
sql/query.py 70.98% <0.00%> (-0.45%) ⬇️
sql/engines/goinception.py 80.76% <11.11%> (+1.05%) ⬆️
sql/utils/data_masking.py 90.15% <87.93%> (+81.06%) ⬆️
sql/engines/tests.py 99.85% <100.00%> (ø)
sql/utils/tests.py 100.00% <100.00%> (ø)
sql/models.py 96.65% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66c77f...43f5d61. Read the comment docs.

@unknowissue
Copy link
Contributor

@unknowissue 有时间可以给看看

哈哈哈哈哈哈,我有空学习一下!

@unknowissue
Copy link
Contributor

周末看看,他妈的,这周光搭dg了

@hhyo hhyo deleted the data-masking branch May 21, 2022 02:21
@unknowissue
Copy link
Contributor

#1550

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants