HHH-19383 - validation of NativeQuery result mappings #10085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Apr 25, 2025
Comment on lines
+353
to
+359
| for ( ResultBuilder resultBuilder : resultSetMapping.getResultBuilders() ) { | ||
| final Class rbJavaType = resultBuilder.getJavaType(); | ||
| if ( !resultType.isAssignableFrom( rbJavaType ) ) { | ||
| throw new IllegalArgumentException( "The result set mapping of the typed query doesn't match the declared return type" ); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
If there are multiple resultBuilders, shouldn't the resultType be Object[]?
There was a problem hiding this comment.
Not necessarily, at least that is what I thought?
If the return type is Object[], there's really not much to check since that flag covers everything.
For that reason I initially surrounded that for loop with if ( resultType != Object[].class ) , but it should already be covered by the outer if.
There was a problem hiding this comment.
I mean this should be an error:
s.createNativeQuery("select title, isbn from books", String.class)
.addScalar("title", String.class)
.addScalar("isbn", String.class)
.getResultList();The result type of that query has to be Object[], not String.
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
jrenaat
force-pushed
the
HHH-19383_checkResultType
branch
from
5869a45 to
53675e6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19383