build(deps): bump org.junit.jupiter:junit-jupiter-api from 5.11.4 to 5.12.2 in /hiero-dependency-versions #1014
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.11.4...r5.12.2) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-api dependency-version: 5.12.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
|
@jjohannes, we found this dependency discrepancy and also found a potential Thank you 🙏 |
|
Blocking until after refactor |
This reverts commit 9cb64af. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
|
Your change fixes the problem indirectly, but we can do it simpler and more consistent with the notations we use. The problem is not the versions we define. We already have a setup where all projects use versions consistently based on what is defined in What you see is that the versions are the same, BUT in the first run If the launcher is missing, Gradle takes one packaged into Gradle itself with whatever version Gradle has packaged (hidden to us). Which can cause issues as the one we are seeing. That's why this is deprecated and one should define the launcher dependency explicitly. Gradle does this for you in the "standard" test setup through the "newer" test suites API. That's what is used when you run the Here however, you have the custom setup where the test code is in |
|
@jjohannes, Thank you for the very detailed and referenced explanation, read a ton of stuff today! 💯 |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Nana-EC
deleted the
dependabot/gradle/hiero-dependency-versions/org.junit.jupiter-junit-jupiter-api-5.12.2
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1014 +/- ##
============================================
+ Coverage 88.33% 88.45% +0.12%
- Complexity 736 741 +5
============================================
Files 134 135 +1
Lines 3154 3171 +17
Branches 237 241 +4
============================================
+ Hits 2786 2805 +19
+ Misses 298 297 -1
+ Partials 70 69 -1 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Bumps org.junit.jupiter:junit-jupiter-api from 5.11.4 to 5.12.2.
Release notes
Sourced from org.junit.jupiter:junit-jupiter-api's releases.
... (truncated)
Commits
0a44659Release 5.12.24c7dfdcFinalize 5.12.2 release notes561613eFix handling ofCleanupMode.ON_SUCCESS19d07d2Add 5.12.2 release notes from template803cbb6Add build parameter for enabling dry-run mode for test executioneb43e62Back to snapshots for further developmentba9c9aeRelease 5.12.1e28ad4aFinalize 5.12.1 release notes1044e2cMove entry to 5.12.1 release notesbea821dFix Javadoc formattingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)