Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: used fixtures in tests #2914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

venilinvasilev
Copy link
Contributor

@venilinvasilev venilinvasilev commented Mar 4, 2025

Description:

This refactors parts of the integration tests to use fixtures.
Adds new fixtures to be used in other tests.
Changes the way transaction state is handled in fixtures, so it is consistent as in usage.

Related issues:

#2872

@venilinvasilev venilinvasilev requested a review from a team as a code owner March 4, 2025 10:26
@venilinvasilev venilinvasilev force-pushed the refactor/use-fixtures-in-integration-tests branch from d256c47 to 980f0aa Compare March 4, 2025 10:27
@venilinvasilev venilinvasilev marked this pull request as draft March 4, 2025 10:32
@venilinvasilev venilinvasilev force-pushed the refactor/use-fixtures-in-integration-tests branch 2 times, most recently from c48f1ac to 4f1f6c8 Compare March 4, 2025 13:30
@venilinvasilev venilinvasilev marked this pull request as ready for review March 4, 2025 13:31
@venilinvasilev venilinvasilev force-pushed the refactor/use-fixtures-in-integration-tests branch from 4f1f6c8 to 2307722 Compare March 4, 2025 13:55
Refactor fixtures to use set methods for modification of state.
Add more fixtures.

Signed-off-by: venilinvasilev <venilin.vasilev@gmail.com>
@venilinvasilev venilinvasilev force-pushed the refactor/use-fixtures-in-integration-tests branch from 2307722 to 591f399 Compare March 4, 2025 16:20
@venilinvasilev venilinvasilev requested a review from a team as a code owner March 4, 2025 16:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant