-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update(excel) from 2016 to 2024 with new formulae #4182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove: FALSE|0 MIDBs SQL.REQUEST TRUE|0 Add: ARRAYTOTEXT BYCOL BYROW CHOOSECOLS CHOOSEROWS DROP EXPAND FALSE FILTER HSTACK IMAGE ISOMITTED LAMBDA LET MAKEARRAY MAP MIDB RANDARRAY REDUCE SCAN SEQUENCE SORT SORTBY STOCKHISTORY TAKE TEXTAFTER TEXTBEFORE TEXTSPLIT TOCOL TOROW TRUE UNIQUE VALUETOTEXT VSTACK WRAPCOLS WRAPROWS XLOOKUP XMATCH
joshgoebel
reviewed
Dec 5, 2024
I have left in SQL.REQUEST, this was from an addin that was included in Excel pre-2010 and is no longer used. Perhaps people want to highlight it in code for older Excel versions. I've removed MIDBs - this was clearly a typo and should have been MIDB which I have added. I've removed TRUE|0 and FALSE|0 and replaced them with TRUE and FALSE which are both callable as functions. The "|0" does not appear in the original archived link, so unless you can think of a reason for it (perhaps it handles the fact that TRUE and FALSE are also valid data not as a function) I will leave removed.
Better! you'll need to add an entry to CHANGES also. |
joshgoebel
reviewed
Dec 11, 2024
joshgoebel
reviewed
Dec 14, 2024
joshgoebel
approved these changes
Dec 14, 2024
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +278 B View Changes
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove:
FALSE|0
MIDBs
SQL.REQUEST
TRUE|0
Add:
ARRAYTOTEXT
BYCOL
BYROW
CHOOSECOLS
CHOOSEROWS
DROP
EXPAND
FALSE
FILTER
HSTACK
IMAGE
ISOMITTED
LAMBDA
LET
MAKEARRAY
MAP
MIDB
RANDARRAY
REDUCE
SCAN
SEQUENCE
SORT
SORTBY
STOCKHISTORY
TAKE
TEXTAFTER
TEXTBEFORE
TEXTSPLIT
TOCOL
TOROW
TRUE
UNIQUE
VALUETOTEXT
VSTACK
WRAPCOLS
WRAPROWS
XLOOKUP
XMATCH
Changes
Checklist
CHANGES.md