Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think the generated equals code is somewhat flawed by creating equals methods that are not symmetric. We actually had a problem with this in our project, because adding a supertype to a HashSet would prevent any subtype with no preinitialized properties to be added to the Set, while the other way around adding is possible (the instanceof check instead of type equality). Thus this can lead to really erratic behavior (in our case we injected multibound generated classes via Guice and depending on the order Guice decided to add these types to the Set to inject, we ended up with a different amount of elements).
Greetings,
Peter