Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make simple equals symmetrical as well #40

Merged
merged 1 commit into from
Nov 22, 2015

Conversation

codecholeric
Copy link

Hi,

we were on an old version of jaxb2-basics for a long while, so I just saw, that actually SimpleEquals would be completely sufficient for our needs (we have no custom equals strategy). Would you be up for merging the equals fix into SimpleEquals as well? Then we could switch to -XsimpleEquals in our project.

Thank you and greetings,
Peter

@ja6a
Copy link

ja6a commented Nov 21, 2015

+1

On 21 Nov 2015, at 6:36 p.m., petega notifications@github.com wrote:

Hi,

we were on an old version of jaxb2-basics for a long while, so I just saw, that actually SimpleEquals would be completely sufficient for our needs (we have no custom equals strategy). Would you be up for merging the equals fix into SimpleEquals as well? Then we could switch to -XsimpleEquals in our project.

Thank you and greetings,
Peter

You can view, comment on, or merge this pull request online at:

#40

Commit Summary

Make simple equals symmetrical if one compares a supertype and a subtype with no unequal properties
File Changes

M basic/src/main/java/org/jvnet/jaxb2_commons/plugin/simpleequals/SimpleEqualsPlugin.java (10)
Patch Links:

https://github.com/highsource/jaxb2-basics/pull/40.patch
https://github.com/highsource/jaxb2-basics/pull/40.diff

Reply to this email directly or view it on GitHub.

highsource added a commit that referenced this pull request Nov 22, 2015
Make simple equals symmetrical as well
@highsource highsource merged commit 4844d11 into highsource:master Nov 22, 2015
@highsource
Copy link
Owner

Great, just how I'd wrote this. Merged, so I'll do the 0.10.x release now. Hope it will work with this internet here...

@highsource highsource added the bug label Nov 22, 2015
@highsource highsource added this to the 0.10.x milestone Nov 22, 2015
@highsource highsource self-assigned this Nov 22, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants