Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

11 add edit delete project #12

Merged
merged 2 commits into from
Apr 28, 2020
Merged

11 add edit delete project #12

merged 2 commits into from
Apr 28, 2020

Conversation

amosnjoroge
Copy link
Collaborator

What is the Purpose?

Add tests to add, edit and delete project

What was the approach?

Add tests to add, edit and delete project

Are there any concerns to addressed further before or after merging this PR?

Mentions?

@TAnas0

Issue(s) affected?

#11

@amosnjoroge amosnjoroge requested a review from TAnas0 April 27, 2020 13:26
@TAnas0
Copy link
Contributor

TAnas0 commented Apr 27, 2020

The test suite looks good and runs well locally 👍

It fails at the very last assertion because it found a bug: the project's code is set to None in the table even if it is defined:

In the list:

Screenshot from 2020-04-27 22-05-10

In the project's edit:

Screenshot from 2020-04-27 22-05-25

@TAnas0 TAnas0 mentioned this pull request Apr 27, 2020
@TAnas0 TAnas0 merged commit e8c2b6e into master Apr 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants