date: fix panic with leading zeros #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, that's embarrassing. Thanks for the really clean fix. |
|
Haha, it happens! Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out Festival today and it kept crashing when trying to import my files. On inspection, it was because one of my files had a date tag of
0305. CallingDate::from_str_silent("0305")was panicking when callingBuffer::from_4_uncheckedbecause theu16value only had 3 bytes instead of 4.This PR adds an additional check to make sure the parsed
u16value is at least1000to prevent leading zeros from causing this issue.