Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use the built-in abortable async setTimeout from node:timers/promises #33

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Mar 4, 2025

Nodejs has built-in async timeouts so we don't need our own bug prone implementation.

@zone117x zone117x requested a review from rafaelcr March 4, 2025 16:51
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@zone117x zone117x merged commit 954e7ea into master Mar 4, 2025
4 checks passed
@zone117x zone117x deleted the fix/use-nodejs-sleep-builtin branch March 4, 2025 17:11
blockstack-devops pushed a commit that referenced this pull request Mar 4, 2025
## [1.7.3](v1.7.2...v1.7.3) (2025-03-04)

### Bug Fixes

* use the built-in abortable async setTimeout from `node:timers/promises` rather than implementing ourselves ([#33](#33)) ([954e7ea](954e7ea))
@blockstack-devops
Copy link

🎉 This PR is included in version 1.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants