-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: update codec #1524
refactor: update codec #1524
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'm curious if we could instead refactor the code in stacks-core and just directly import a crate for this?
85e71c1
to
784e2f6
Compare
0d07ef9
to
8817565
Compare
* chore: nakamoto block header * chore: nakamotoblock * chore: signer message
8817565
to
6a92863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Mostly code pulled from stacks-core
This PR also cascades the changes following the removal of wsts and the clarity 3 changes with
get_stacks_height_for_tenure_height