Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: update codec #1524

Merged
merged 4 commits into from
Oct 22, 2024
Merged

refactor: update codec #1524

merged 4 commits into from
Oct 22, 2024

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Jul 31, 2024

Mostly code pulled from stacks-core
This PR also cascades the changes following the removal of wsts and the clarity 3 changes with get_stacks_height_for_tenure_height

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0.59102% with 841 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/stacks-codec/src/codec.rs 0.00% 834 Missing ⚠️
components/clarity-repl/src/repl/datastore.rs 41.66% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

obycode
obycode previously approved these changes Aug 1, 2024
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm curious if we could instead refactor the code in stacks-core and just directly import a crate for this?

@hugocaillard hugocaillard force-pushed the feat/update-stacks-codec branch from 85e71c1 to 784e2f6 Compare October 14, 2024 10:06
@hugocaillard hugocaillard marked this pull request as ready for review October 14, 2024 21:52
@hugocaillard hugocaillard requested a review from rafaelcr October 14, 2024 21:52
@hugocaillard hugocaillard force-pushed the feat/update-stacks-codec branch 2 times, most recently from 0d07ef9 to 8817565 Compare October 21, 2024 15:58
@hugocaillard hugocaillard force-pushed the feat/update-stacks-codec branch from 8817565 to 6a92863 Compare October 21, 2024 16:06
Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hugocaillard hugocaillard merged commit 7d1db47 into main Oct 22, 2024
19 checks passed
@hugocaillard hugocaillard deleted the feat/update-stacks-codec branch October 22, 2024 09:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants