feat: add costs report in sdk tx response #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
changed the title
hugocaillard
force-pushed
the
feat/costs-in-sdk-tx-result
branch
from
ee8cc7a to
ec98242
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
hugocaillard
force-pushed
the
feat/costs-in-sdk-tx-result
branch
from
ec98242 to
8892a9e
Compare
hugocaillard
force-pushed
the
feat/costs-in-sdk-tx-result
branch
from
8892a9e to
e06af6b
Compare
tippenein
approved these changes
Dec 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1507
Return tx costs in the js sdk.
This will be useful for transaction simulation, costs evaluation can help with fees estimation of a tx for instance
Some of the code could be simplified thanks to stacks-network/stacks-core#5534