feat: store total transaction size in blocks table #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-8kcg3xjul-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
janniks
approved these changes
Jan 22, 2025
|
thanks @janniks , exactly, they're only simulated values for tests |
zone117x
reviewed
Jan 24, 2025
Comment on lines
+5
to
+20
| exports.up = pgm => { | ||
| pgm.addColumn('blocks', { | ||
| tx_total_size: { | ||
| type: 'int', | ||
| notNull: true, | ||
| default: 0, | ||
| }, | ||
| }); | ||
| pgm.sql(` | ||
| UPDATE blocks | ||
| SET tx_total_size = ( | ||
| SELECT SUM(OCTET_LENGTH(raw_tx)) | ||
| FROM txs | ||
| WHERE index_block_hash = blocks.index_block_hash | ||
| ) | ||
| `); |
There was a problem hiding this comment.
My gut feeling is that this will result in a several hour long migration for most external deployments (e.g. exchanges). Seems like it would be fine to let the new column be nullable and we'd only have this available for new blocks.
blockstack-devops
pushed a commit
that referenced
this pull request
Jan 28, 2025
## [8.6.0-beta.1](v8.5.0...v8.6.0-beta.1) (2025-01-28) ### Features * consider tenure block fullness for transaction fee estimations ([#2203](#2203)) ([396e2ea](396e2ea)) * store total transaction size in blocks table ([#2204](#2204)) ([ac7c41b](ac7c41b)) ### Bug Fixes * make tx_total_size column nullable ([#2207](#2207)) ([77bd2f8](77bd2f8))
|
🎉 This PR is included in version 8.6.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is computed by the sum of all confirmed transaction byte sizes, and will be necessary to calculate tenure fullness in fee estimations.