Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Add missing post-condition conversion functions #1790

Merged
merged 4 commits into from
Mar 10, 2025
Merged

fix: Add missing post-condition conversion functions #1790

merged 4 commits into from
Mar 10, 2025

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Mar 7, 2025 •
edited by github-actions bot
Loading

This PR was published to npm with the version 7.0.5-pr.3+5beb8cef
e.g. npm install @stacks/common@7.0.5-pr.3+5beb8cef --save-exact

  • adds a few new functions to make deserializing post conditions easier.

@vercel Vercel
Copy link

vercel bot commented Mar 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 11:13am

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/transactions/src/postcondition.ts 85.71% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks requested a review from zone117x March 10, 2025 11:13
@janniks janniks requested a review from ASuciuX March 10, 2025 11:16
ASuciuX
ASuciuX approved these changes Mar 10, 2025
View reviewed changes
Copy link

@ASuciuX ASuciuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janniks janniks merged commit a617f65 into main Mar 10, 2025
10 checks passed
@janniks janniks deleted the fix/add-missing-postcondition-conversion branch March 10, 2025 12:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ASuciuX ASuciuX ASuciuX approved these changes

@zone117x zone117x Awaiting requested review from zone117x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @ASuciuX