Updated error showing and keyboard behaviour #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, don't want to be published on readme, but thought these changes necessary. The .min and .max error messages of yup passwordSchema was not showing. So I removed touched.passwordLength and it worked for me. Moreover, these long error messages was pushing textInput field out of view so I added width: 200 to styles.errorText and it worked nicely. Moreover, keyboard wasn't hiding automatically when I clicked Generate Password so I added Keyboard.dismiss() from the react native Keyboard module. After addition, it started working nicely.
|
@hiteshchoudhary Please review. It's worth reviewing! Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, don't want to be published on readme, but thought these changes necessary. The .min and .max error messages of yup passwordSchema was not showing. So I removed touched.passwordLength and it worked for me. Moreover, these long error messages was pushing textInput field out of view so I added width: 200 to styles.errorText and it worked nicely. Moreover, keyboard wasn't hiding automatically when I clicked Generate Password so I added Keyboard.dismiss() from the react native Keyboard module. After addition, it started working nicely.