-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(30019): Split the openAPI file #856
Conversation
See ext/openAPI/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also in favour of removing the ext/openAPI/hivemq-edge-openapi-master.yaml
file, so that we don't maintain two documents that might end up diverging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one.
I ran tests locally and all looks good.
e53cbd5
to
0b6481b
Compare
See https://hivemq.kanbanize.com/ctrl_board/57/cards/30019/details/
The PR splits the original single
YAML
document into a structured multi-files system.Out-of-scope
IntelliJ
(backend) andWebStorm
orVSCode
(frontend) are using different linting processes for "cleaning"YAML
documents and commits will result in changes that are purely aesthetic. A common linting set of rules should be added to theOpenAPI
"repo".,Edge OpenAPI Specifications
Structure
The main document has been split from the original source in order to reduce the size of a single document and to highlight individual points of concern.
The original split was done automatically (using
redocly
see below) and the files reflects the automation.There is no reason to maintain such naming convention as we manually add or edit the source.
Usage
The redocly library is used to manage the OpenAPI specs, stored as a split document.
Bundle
Some of the tools handling OpenAPi will be working fine with a split document.
If not, consider bundling it into a single
YAML
file, using the following command:Make sure NOT to commit your bundled document along the split origin; we need to ensure a single source of truth.
Split
To reverse the merge operation and create a split document, the following command will deliver:
GitHub guidelines
OpenAPI
specs define in this document is the only source of truth of theEdge
REST API.