Skip to content

Commit

Permalink
COMP: Fix error in Windows Python CI build
Browse files Browse the repository at this point in the history
This is a follow-up to commit 4cbe24c,
PR InsightSoftwareConsortium#5030: InsightSoftwareConsortium#5030

The error message was:

FAILED: Wrapping/Generators/Python/itk/ITKCommon-6.0.dll lib/ITKCommon-6.0.lib
C:\Windows\system32\cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_dll --msvc-ver=1929 --intdir=Modules\Core\Common\src\CMakeFiles\ITKCommon.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\ITKCommon.rsp  /out:Wrapping\Generators\Python\itk\ITKCommon-6.0.dll /implib:lib\ITKCommon-6.0.lib /pdb:Wrapping\Generators\Python\itk\ITKCommon-6.0.pdb /dll /version:1.0 /machine:x64  /INCREMENTAL:NO && cd ."
LINK: command "C:\PROGRA~2\MICROS~2\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\ITKCommon.rsp /out:Wrapping\Generators\Python\itk\ITKCommon-6.0.dll /implib:lib\ITKCommon-6.0.lib /pdb:Wrapping\Generators\Python\itk\ITKCommon-6.0.pdb /dll /version:1.0 /machine:x64 /INCREMENTAL:NO /MANIFEST:EMBED,ID=2" failed (exit code 1104) with the following output:
LINK : fatal error LNK1104: cannot open file 'python311.lib'

Closes InsightSoftwareConsortium#5075.
  • Loading branch information
dzenanz authored and hjmjohnson committed Dec 18, 2024
1 parent 74916a5 commit d6d67c4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions Modules/Core/Common/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ configure_file(src/itkConfigurePrivate.h.in itkConfigurePrivate.h)

if(ITK_WRAP_PYTHON)
set(ITKCommon_SYSTEM_INCLUDE_DIRS "${Python3_INCLUDE_DIRS}")
set(ITKCommon_SYSTEM_LIBRARY_DIRS "${Python3_LIBRARY_DIRS}")
endif()
set(ITKCommon_INCLUDE_DIRS ${ITKCommon_BINARY_DIR})
set(ITKCommon_LIBRARIES ITKCommon)
Expand Down
3 changes: 2 additions & 1 deletion Modules/Core/Common/include/itkPyCommand.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ namespace itk
*
* This class was contributed by Charl P. Botha <cpbotha |AT| ieee.org>
*
* \ingroup ITKSystemObjects
* \ingroup ITKCommon
*/
class PyCommand : public Command
class ITKCommon_EXPORT PyCommand : public Command
{
public:
///! Standard "Self" typedef.
Expand Down

0 comments on commit d6d67c4

Please # to comment.