This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* HMIS-945: Policy changes to validate response codes * HMIS-945: Unit test and env config changes to make Direct Hearing a PUT request. * HMIS-945: Review comments incoporated. * HMIS-945: Review comments incoporated. * refactored tests to reflect updated API * HMIS-939: Enable functional tests for elinks. * HMIS-945: Re-enable unit tests for direct hearing * Create infra and app pipeline * Correct formatting * infra only deploys infra and no tests * remove dependency * handle 500 response * HMIS-939: Re-enable unit tests for direct hearing * added SNow call * implemented 500 behaviour * Add depends on Default * correct dependency * updated short desc * add dependency defauls * change dependent for build * transaction id used for SNow * add dependency * remove dependency * returning SNOW number * added snowHost * added keyVaultHost Co-authored-by: 463952 <subroto.mukherjee@HMCTS.NET> Co-authored-by: Subroto Mukherjee <53174127+subrotomukherjee@users.noreply.github.com> Co-authored-by: Matthew Summerbell <79512635+Matthew-Summerbell@users.noreply.github.com> Co-authored-by: Matthew Summerbell <matt.summerbell@HMCTS.NET> Co-authored-by: Christopher Pateman <christopher.pateman@version1.com> Co-authored-by: chris-pateman <86669094+chris-pateman@users.noreply.github.com> Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com>
* HMIS-945: Policy changes to validate response codes * HMIS-945: Unit test and env config changes to make Direct Hearing a PUT request. * HMIS-945: Review comments incoporated. * HMIS-945: Review comments incoporated. * refactored tests to reflect updated API * HMIS-939: Enable functional tests for elinks. * HMIS-945: Re-enable unit tests for direct hearing * Create infra and app pipeline * Correct formatting * infra only deploys infra and no tests * remove dependency * handle 500 response * HMIS-939: Re-enable unit tests for direct hearing * added SNow call * implemented 500 behaviour * Add depends on Default * correct dependency * updated short desc * add dependency defauls * change dependent for build * transaction id used for SNow * add dependency * remove dependency * returning SNOW number * added snowHost * added keyVaultHost * Hmi rota dtu (#465) * added scope as param * added scope param definition * updated stg hmi host * updated with prod info * pinned version * stopped analysis * removed ver * added version * added debug * restored * added schedule extraction * added schedule processing * added CLPorfile processing * completed data extractioins * retrival of CLP info * populating request * johid population * raw * SN1 params * uri param * assignment_group * caller_id * service_offering * u_role_type * assignment_group 2 * SN2 params * hmi schedules param * new flow * added params * renamed generic actions * update SN descriptioin * storage acc name * removed SA param * using concat * added param * using path param * replaced all with param * added SAGetPath param * foreaach file param added * added missing params * corrected apim host name * Hmis 909 (#410) * Hmi rota dtu (#409) * added scope as param * added scope param definition * updated stg hmi host * updated with prod info * pinned version * stopped analysis * removed ver * added version * added debug * restored Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> * adding missing brackets, malformed yaml * formatting * syntax * removing unneeded bracket * moving ) as required * added schedule extraction * added schedule processing * added CLPorfile processing * completed data extractioins * retrival of CLP info * populating request * johid population * raw * SN1 params * uri param * assignment_group * caller_id * service_offering * u_role_type * assignment_group 2 * SN2 params * hmi schedules param * new flow * added params * renamed generic actions * update SN descriptioin * storage acc name * removed SA param * using concat * added param * using path param * replaced all with param * added SAGetPath param * foreaach file param added * added missing params * corrected apim host name Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Cary Corse <cary.corse@evoco.co.uk> * corrected SA name * Hmis 909 (#411) * Hmi rota dtu (#409) * added scope as param * added scope param definition * updated stg hmi host * updated with prod info * pinned version * stopped analysis * removed ver * added version * added debug * restored Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> * adding missing brackets, malformed yaml * formatting * syntax * removing unneeded bracket * moving ) as required * added schedule extraction * added schedule processing * added CLPorfile processing * completed data extractioins * retrival of CLP info * populating request * johid population * raw * SN1 params * uri param * assignment_group * caller_id * service_offering * u_role_type * assignment_group 2 * SN2 params * hmi schedules param * new flow * added params * renamed generic actions * update SN descriptioin * storage acc name * removed SA param * using concat * added param * using path param * replaced all with param * added SAGetPath param * foreaach file param added * added missing params * corrected apim host name * corrected SA name Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Cary Corse <cary.corse@evoco.co.uk> * Hmis 909 (#413) * Hmi rota dtu (#409) * added scope as param * added scope param definition * updated stg hmi host * updated with prod info * pinned version * stopped analysis * removed ver * added version * added debug * restored Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> * adding missing brackets, malformed yaml * formatting * syntax * removing unneeded bracket * moving ) as required * added schedule extraction * added schedule processing * added CLPorfile processing * completed data extractioins * retrival of CLP info * populating request * johid population * raw * SN1 params * uri param * assignment_group * caller_id * service_offering * u_role_type * assignment_group 2 * SN2 params * hmi schedules param * new flow * added params * renamed generic actions * update SN descriptioin * storage acc name * removed SA param * using concat * added param * using path param * replaced all with param * added SAGetPath param * foreaach file param added * added missing params * corrected apim host name * corrected SA name Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Cary Corse <cary.corse@evoco.co.uk> * added XML validation * Hmis 909 (#415) * Hmi rota dtu (#409) * added scope as param * added scope param definition * updated stg hmi host * updated with prod info * pinned version * stopped analysis * removed ver * added version * added debug * restored Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> * adding missing brackets, malformed yaml * formatting * syntax * removing unneeded bracket * moving ) as required * added schedule extraction * added schedule processing * added CLPorfile processing * completed data extractioins * retrival of CLP info * populating request * johid population * raw * SN1 params * uri param * assignment_group * caller_id * service_offering * u_role_type * assignment_group 2 * SN2 params * hmi schedules param * new flow * added params * renamed generic actions * update SN descriptioin * storage acc name * removed SA param * using concat * added param * using path param * replaced all with param * added SAGetPath param * foreaach file param added * added missing params * corrected apim host name * corrected SA name * HMIS-907 * HMIS-910 block PR triggers * added XML validation Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Cary Corse <cary.corse@evoco.co.uk> Co-authored-by: 463952 <subroto.mukherjee@HMCTS.NET> Co-authored-by: Christopher Pateman <christopher.pateman@version1.com> Co-authored-by: chris-pateman <86669094+chris-pateman@users.noreply.github.com> Co-authored-by: Matthew Summerbell <79512635+Matthew-Summerbell@users.noreply.github.com> * updated SA path * convert to Xml before Json * Hmis 909 (#416) * secondary SNow call added * capture parse error in desc * cater for 5xx errors * XML content check for ROTA * updated valiidation check forXML ROTA * fixed AM-PM check Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> * Hmis 909 (#417) * secondary SNow call added * capture parse error in desc * cater for 5xx errors * XML content check for ROTA * updated valiidation check forXML ROTA * fixed AM-PM check * removed 's' * updated storage account path * restored http code checks Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> * Hmis 909 (#420) * secondary SNow call added * capture parse error in desc * cater for 5xx errors * XML content check for ROTA * updated valiidation check forXML ROTA * fixed AM-PM check * removed 's' * updated storage account path * restored http code checks * HMI response check for failure * VIH-7898 add APIM checking * VIH-7898 add resources * removed HMI calls * magistrate parsing failure * magistrate exception stored in error file * invalid judges and clp files generated * invalid sessios check * create error file for schedules * added clean of repo folders * updated missing params * added extra params for CLP,Magistrates & Schedules * added params * creation of read.me added * removed parallel processing of read.me * creating schedule files * closing loop for deletion * restored grouping * VIH-7898 Add APIM Check * refactored cleaning of repo folders * renamed creation of schedules * path params adjusted * updated path values * updated parameters * using variables for path to ListBlob * using calc path * detection of failed schedules * deletion of schedulee files on error * added calls to HMI * HMI error processing added * sending schedule errors as sigle SN incident * moved checks before repo clean * SN call invalid schedules * SN call when invalid scheedules repo * renamed SN call * added schedule if to error body Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Christopher Pateman <christopher.pateman@version1.com> Co-authored-by: chris-pateman <86669094+chris-pateman@users.noreply.github.com> * corrected loop * Corrected HMI request payload * trigger 8hr * check HMI failure on success & fail * repo clearing adjusted to proceed if 404 * raw dev * corrected template * removed del * wip: create read.me * moved repo read.me creation * deletion of source xml reinstated * added param hmiDestination * read.me creation added for schedules error * using MOCK for HMI calls * raw changes * params added for storageACPathFiles * added second parameter * added connector * removed additional props forr table connector * moved johs * added errors from table lookups * updated table connection with param * added azuretable to depends * added params for Snow calls * added param hmiDestination * source system CRIME * added shcedules url param * added shared key * added paramValues to connector * updated paaram for SN url * delete tablee contents before loading * added failure check * capture HMI error * using response body instead of error * Update parameters-test.json (#453) * Update parameters-test.json * using RowKey instead of emailAddress * reverted change * Hmi rota dtu patch test snl (#454) * Update parameters-test.json * using RowKey instead of emailAddress * reverted change * Hmi rota dtu patch snl (#459) * updated to call SNL * fixed time format and johs structure * joh json creation * updated sessionDuration to 360 for AM * renamed variable * using locationId * AM session duration 180 Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> * added JOH to table and clear prev value (#460) * added JOH to table and clear prev value * table update sequential Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Cary Corse <cary.corse@evoco.co.uk> Co-authored-by: 463952 <subroto.mukherjee@HMCTS.NET> Co-authored-by: Christopher Pateman <christopher.pateman@version1.com> Co-authored-by: chris-pateman <86669094+chris-pateman@users.noreply.github.com> Co-authored-by: Matthew Summerbell <79512635+Matthew-Summerbell@users.noreply.github.com> * corrected response message for 500 * added HMI ref * added missing ')' * added missin qute * message changes * updated SNow description * corrected description Co-authored-by: 463952 <subroto.mukherjee@HMCTS.NET> Co-authored-by: Subroto Mukherjee <53174127+subrotomukherjee@users.noreply.github.com> Co-authored-by: Matthew Summerbell <79512635+Matthew-Summerbell@users.noreply.github.com> Co-authored-by: Matthew Summerbell <matt.summerbell@HMCTS.NET> Co-authored-by: Christopher Pateman <christopher.pateman@version1.com> Co-authored-by: chris-pateman <86669094+chris-pateman@users.noreply.github.com> Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Cary Corse <cary.corse@evoco.co.uk>
* handle 500 response * added SNow call * implemented 500 behaviour * Add depends on Default * correct dependency * updated short desc * transaction id used for SNow * add dependency * remove dependency * returning SNOW number * added snowHost * added keyVaultHost * corrected response message for 500 * added HMI ref * added missing ')' * added missin qute * message changes * updated SNow description * corrected description * Gatiway correction * Gatiway correction Co-authored-by: Milan Jotic <milan.jotic@beo-tech.com> Co-authored-by: Christopher Pateman <christopher.pateman@version1.com>
…ay-fh into hmi-error-servicenow
subrotomukherjee
approved these changes
Dec 13, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
server error will generate Service Now ticket
Does this PR introduce a breaking change? (check one with "x")