Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DDCE-6058 - Removing scopes from API definition #136

Merged
merged 4 commits into from
Sep 17, 2024
Merged

DDCE-6058 - Removing scopes from API definition #136

merged 4 commits into from
Sep 17, 2024

Conversation

mithra-balakrishnan
Copy link
Contributor

DDCE-6058 - Removing scopes from API definition

@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.22.0 in project/plugins.sbt
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated

@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.22.0 in project/plugins.sbt
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated

@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.22.0 in project/plugins.sbt
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback-test.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback-test.xml - it's never populated

@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.22.0 in project/plugins.sbt
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback.xml - it's never populated
  • STDOUT_IGNORE_NETTY appender (and usage) can be removed from conf/logback-test.xml - Netty server is no longer used (Since Play 2.6.x)
  • ACCESS_LOG_FILE appender (and usage) can be removed from conf/logback-test.xml - it's never populated

MRBeresford
MRBeresford approved these changes Sep 17, 2024
View reviewed changes
Copy link

@MRBeresford MRBeresford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mithra-balakrishnan mithra-balakrishnan merged commit 8e1f6ea into main Sep 17, 2024
1 check passed
@mithra-balakrishnan mithra-balakrishnan deleted the DDCE-6058 branch September 17, 2024 11:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MRBeresford MRBeresford MRBeresford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mithra-balakrishnan @platops-pr-bot @MRBeresford