SASS-10418: UK Rent a Room - Adjustments section: Update Intro and 'Check your answers' pages #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StuartJamesProctor
force-pushed
the
SASS-10418
branch
from
6695fc3 to
141c320
Compare
tbg2003
reviewed
Feb 19, 2025
tbg2003
reviewed
Feb 19, 2025
tbg2003
requested changes
Feb 20, 2025
tbg2003
previously approved these changes
Feb 20, 2025
app/models/repository/Merger.scala
Outdated
| unusedLossesBroughtForward = Some( | ||
| UnusedLossesBroughtForward( | ||
| unusedLossesBroughtForwardYesOrNo = extractedMaybe | ||
| .map(_.unusedLossesBroughtForward.exists(_.unusedLossesBroughtForwardYesOrNo == true)) |
app/models/repository/Merger.scala
Outdated
| @@ -425,12 +425,21 @@ object Merger { | |||
| balancingCharge = Some( | |||
| BalancingCharge( | |||
| balancingChargeYesNo = extractedMaybe | |||
| .map(_.raRBalancingChargeYesNo) | |||
| .map(_.balancingCharge.exists(_.balancingChargeYesNo == true)) | |||
There was a problem hiding this comment.
I think we need to properly handle balancingChargeYesNo.
Suggested change
| .map(_.balancingCharge.exists(_.balancingChargeYesNo == true)) | |
| .flatMap(_.balancingCharge.map(_.balancingChargeYesNo)) |
# Conflicts: # app/models/responses/PropertyAnnualSubmission.scala
# Conflicts: # it/test/connectors/IntegrationFrameworkConnectorSpec.scala
StuartJamesProctor
force-pushed
the
SASS-10418
branch
from
cbdb120 to
d4fa648
Compare
tbg2003
approved these changes
Feb 21, 2025
vivekhmrc
approved these changes
Feb 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.