Psr 71 #10
Merged
Psr 71 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narendrapaduchuri
previously approved these changes
Jan 24, 2023
westwater
reviewed
Jan 24, 2023
| collection | ||
| .updateOne( | ||
| filter = byId(id), | ||
| update = Updates.set("lastUpdated", Instant.now(clock)), | ||
| ) | ||
| .toFuture | ||
| .map(_ => true) | ||
| .as(()) |
There was a problem hiding this comment.
minor: do you think it's worth adding an extra function to FutureOps to handle this case? (like .unit in cats)
westwater
reviewed
Jan 24, 2023
| import play.api.mvc.Call | ||
| import viewmodels.DisplayMessage | ||
|
|
||
| case class ContentPageViewModel( |
westwater
previously approved these changes
Jan 24, 2023
kurtlogan
dismissed stale reviews from westwater and narendrapaduchuri
via
f7b9009
narendrapaduchuri
approved these changes
Jan 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.