Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add toggle to switch between Pango and Nextclade nomenclature #424

Open
AdvancedCodingMonkey opened this issue Dec 2, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request scope: web Related to web app

Comments

@AdvancedCodingMonkey
Copy link
Collaborator

@AdvancedCodingMonkey
Copy link
Collaborator Author

Questions for refinement:

  • There can be multiple pango lineages, which to use?
  • Can alt_display_name be used?
  • Where to place toggle?
  • Home page:
    • Should variants links update?
  • Variants page:
    • Should variants links update?
    • Should the variant urls update?
    • Should we update the individual variants' text?
    • Plot headers need to update
  • Should we add something to the FAQ?
  • per country page:
    • menu and plot headers should update
    • should filter urls update?
  • per variant page:
    • menu and plot headers should update
    • should filter urls update?
  • cases page:
    • menu and plot headers should update
    • should filter urls update?
  • shared mutations page: should table header update? should the text update?
  • acknowledgements: should anything update here?

@AdvancedCodingMonkey
Copy link
Collaborator Author

Further refinement:

  • dealing with multiple pango lineages
    • it is just that one clade
    • not really a chance this happens again
    • concatenating the string or finding a solution just for this one clade is fine
  • can one use alt_display_name
    • in principle yes, the oldest variants need an update though
  • overall strategy
    • variant urls should update and be persistent
    • links to variant pages and page content should update
  • add something to the FAQ
  • filter urls
    • if the switch state is persisted between reloads, should be ok to not have it represented in the url
    • the variant version in the url is probably overkill
  • shared mutations
    • instead of listing both at the same time in the header, update on switch
  • acknowledgements
    • only if it is very very little work

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request scope: web Related to web app
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant