Skip to content

core/state, core/blockchain: split up account/storage prefetch into t… #23

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 7 commits into from

Conversation

holiman
Copy link
Owner

@holiman holiman commented Jan 10, 2021

…wo separate routines

holiman and others added 7 commits January 8, 2021 18:55
Squashed from the following commits:

core/state: lazily init snapshot storage map
core/state: fix flawed meter on storage reads
core/state: make statedb/stateobjects reuse a hasher
core/blockchain, core/state: implement new trie prefetcher
core: make trie prefetcher deliver tries to statedb
core/state: refactor trie_prefetcher, export storage tries
blockchain: re-enable the next-block-prefetcher
state: remove panics in trie prefetcher
core/state/trie_prefetcher: address some review concerns

sq
@holiman
Copy link
Owner Author

holiman commented Jan 10, 2021

Running this on bench03 now, with improve_updates_2 (non-paralell account/storage) on bench04.

@holiman
Copy link
Owner Author

holiman commented Jan 10, 2021

Speed-wise, there's no really dramatic difference (when executing blocks at head at least), but the account-skips have gone down to zero, and storage skips were also improved a bit. And as expected: the delivery-miss chart has gone down:

Screenshot_2021-01-10 Dual Geth - Grafana

@holiman
Copy link
Owner Author

holiman commented Jan 10, 2021

cc @karalabe

@holiman holiman closed this Feb 1, 2021
holiman pushed a commit that referenced this pull request Oct 6, 2021
core, eth: various tiny fixups integrating sync
holiman pushed a commit that referenced this pull request Nov 26, 2022
holiman pushed a commit that referenced this pull request Jul 7, 2023
move tracing docs into new dir
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants