fix: #493 undefined object issue #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holomekc
force-pushed
the
fix/493-undefined-object-issue
branch
from
c463b97 to
8ed4c05
Compare
It seems that the provided object can be undefined. This is a little bit strange to be honest, as the api says the callback is non-null, but maybe I do not understand it properly. We can safely do the check. If _bshbCreated is not set the further checks will still pass.
holomekc
force-pushed
the
fix/493-undefined-object-issue
branch
from
8ed4c05 to
1672da4
Compare
|
🎉 This pull request is included in version 0.4.2 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493
It seems that the provided object can be undefined. This is a little bit strange to be honest, as the
api says the callback is non-null, but maybe I
do not understand it properly. We can safely
do the check. If _bshbCreated is not set the
further checks will still pass.