Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix import map typing #7392

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Fix import map typing #7392

merged 1 commit into from
Oct 13, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

Fix _importmap typing as they are on the form

_importmap = {
        "imports": {
            "mermaid": f"https://cdn.jsdelivr.net/npm/mermaid@{VERSION}/dist/mermaid.esm.min.mjs"
        }
    }

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (ef31354) to head (e99c283).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7392      +/-   ##
==========================================
+ Coverage   82.19%   82.21%   +0.01%     
==========================================
  Files         337      337              
  Lines       50514    50514              
==========================================
+ Hits        41522    41529       +7     
+ Misses       8992     8985       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 323b2ab into main Oct 13, 2024
18 checks passed
@philippjfr philippjfr deleted the fix/importmap-typing branch October 13, 2024 09:38
ahuang11 pushed a commit that referenced this pull request Oct 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants