Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue #7532: Disabled for NestedSelect #7533

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

mayonnaisecolouredbenz7
Copy link
Contributor

Description

This pull request fixes issue #7532 .

Changes Made

  • Fixed the disabled toggle for NestedSelect
  • Not sure if this is it what is required. But is working as expected
  • Documentation doesn't show disabled as a parameter, however the original code did have references to it so looks like it is intended and is inline with other widgets
  • Ran tests locally with pixi before opening this PR

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (4e4c82b) to head (cd675d7).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7533      +/-   ##
==========================================
- Coverage   82.22%   82.21%   -0.02%     
==========================================
  Files         339      339              
  Lines       51321    51322       +1     
==========================================
- Hits        42198    42193       -5     
- Misses       9123     9129       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11
Copy link
Contributor

ahuang11 commented Dec 4, 2024

Thanks for adding this! Can you add it to the reference notebook https://github.com/holoviz/panel/blob/main/examples/reference/widgets/NestedSelect.ipynb and maybe add a test too https://github.com/holoviz/panel/blob/main/panel/tests/widgets/test_select.py#L260 by checking the sub-widgets are disabled too.

Also, maybe you sync loading too.

panel/widgets/select.py Outdated Show resolved Hide resolved
@ahuang11 ahuang11 added this to the v1.5.5 milestone Dec 16, 2024
@philippjfr philippjfr merged commit b7dc332 into holoviz:main Dec 17, 2024
17 of 18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants