Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure esbuild can be detected on windows #7625

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Conversation

philippjfr
Copy link
Member

Fixes #7598

@philippjfr
Copy link
Member Author

Test failure unrelated.

@philippjfr philippjfr merged commit 44fc301 into main Jan 17, 2025
13 of 16 checks passed
@philippjfr philippjfr deleted the check_cli_windows branch January 17, 2025 16:03
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.17%. Comparing base (461b66e) to head (0625e5f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/compile.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7625      +/-   ##
==========================================
- Coverage   86.70%   86.17%   -0.53%     
==========================================
  Files         341      341              
  Lines       51770    51775       +5     
==========================================
- Hits        44888    44619     -269     
- Misses       6882     7156     +274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panel compile not working on windows
2 participants