Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: icon picker suspense issue #1533

Merged
merged 2 commits into from
Nov 24, 2024
Merged

fix: icon picker suspense issue #1533

merged 2 commits into from
Nov 24, 2024

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Previously the whole page showed a loading spinner and most of the times you were not able to enter even one character. Now it just works. Also added a debounce to not spam the server to much.

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Nov 23, 2024
@Meierschlumpf Meierschlumpf self-assigned this Nov 23, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner November 23, 2024 16:56
Copy link

deepsource-io bot commented Nov 23, 2024

Here's the code health analysis summary for commits 4a94d60..3e48ac6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 1 occurence resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.35% 6333 / 29654
🔵 Statements 21.35% 6333 / 29654
🔵 Functions 24.16% 252 / 1043
🔵 Branches 59.23% 805 / 1359
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/components/icons/picker/icon-picker.tsx 0% 0% 0% 0% 1-150
Generated in workflow #3827 for commit 3e48ac6 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit ecf299e into dev Nov 24, 2024
11 checks passed
@Meierschlumpf Meierschlumpf deleted the icon-picker-suspense-bad branch November 24, 2024 12:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants