-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(docker): add support for pgid and puid env variables #1759
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Coverage Report
File CoverageNo changed files found. |
Won't chowning the socket also impact other things using said socket? IE portainer. If so, might want to think about setting a user field that someone can run the container as that will have access to said socket. |
You are right, I didn't know that. I guess then we'll need to add |
What do you think of that solution? We allow the user to change PUID and PGID to whatever they need and chown the volumes the same way and internally still use the |
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm buid
, autofix withpnpm format:fix
)dev
branchx
,y
,i
or any abbrevation)