Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(category): remove not always working and ignoring dynamic sections #1939

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #1923

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Jan 13, 2025
@Meierschlumpf Meierschlumpf self-assigned this Jan 13, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 13, 2025 17:40
Copy link

deepsource-io bot commented Jan 13, 2025

Here's the code health analysis summary for commits 6b36ec3..68fe5b9. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.41% 8095 / 37808
🔵 Statements 21.41% 8095 / 37808
🔵 Functions 24.95% 293 / 1174
🔵 Branches 62.02% 895 / 1443
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/components/board/sections/category/category-actions.ts 0% 0% 0% 0% 1-146
apps/nextjs/src/components/board/sections/category/actions/remove-category.ts 85.71% 81.25% 100% 85.71% 14-15, 28-29, 72-77, 88, 102, 110
Generated in workflow #4581 for commit 68fe5b9 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit d4bb014 into dev Jan 14, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the category-remove-action branch January 14, 2025 18:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: last category is impossible to remove fromt the dashboard
1 participant