Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add tile border radius #2338

Merged
merged 3 commits into from
Feb 18, 2025
Merged

feat: add tile border radius #2338

merged 3 commits into from
Feb 18, 2025

Conversation

manuel-rw
Copy link
Member

@manuel-rw manuel-rw commented Feb 15, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image

Copy link

deepsource-io bot commented Feb 15, 2025

Here's the code health analysis summary for commits 8e71b88..649a81a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 1 occurence resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@manuel-rw manuel-rw force-pushed the feat/add-tile-border-radius branch 5 times, most recently from 249e7ba to 882e4b0 Compare February 15, 2025 21:14
Copy link

github-actions bot commented Feb 15, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.49% 8817 / 41016
🔵 Statements 21.49% 8817 / 41016
🔵 Functions 26.65% 342 / 1283
🔵 Branches 62.15% 997 / 1604
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/boards/[name]/settings/page.tsx 0% 0% 0% 0% 1-156
apps/nextjs/src/components/board/items/item-content.tsx 0% 0% 0% 0% 1-119
apps/nextjs/src/components/board/sections/category-section.tsx 0% 0% 0% 0% 1-53
apps/nextjs/src/components/board/sections/dynamic-section.tsx 0% 0% 0% 0% 1-37
packages/api/src/router/board.ts 58.67% 77.18% 75% 58.67% 41-49, 52-59, 65-90, 166-235, 244-260, 291-416, 435-439, 452-454, 457-459, 467, 534-678, 888, 907, 918-933, 938-939, 961-976, 981-982, 1001-1003, 1028-1030, 1131-1135, 1168-1169
packages/db/schema/mysql.ts 100% 100% 100% 100%
packages/db/schema/sqlite.ts 100% 100% 100% 100%
packages/validation/src/board.ts 100% 50% 100% 100%
Generated in workflow #5176 for commit 649a81a by the Vitest Coverage Report Action

@manuel-rw manuel-rw force-pushed the feat/add-tile-border-radius branch from 882e4b0 to ec3c4ee Compare February 15, 2025 21:18
@manuel-rw manuel-rw self-assigned this Feb 15, 2025
@manuel-rw manuel-rw added the enhancement New feature or request label Feb 15, 2025
@manuel-rw manuel-rw marked this pull request as ready for review February 15, 2025 21:40
@manuel-rw manuel-rw requested a review from a team as a code owner February 15, 2025 21:40
Copy link
Member

@Meierschlumpf Meierschlumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, move it to colors and rename that to appearance to not conflict with the responsive layout system

@manuel-rw manuel-rw force-pushed the feat/add-tile-border-radius branch 2 times, most recently from e11b3dc to 96782a1 Compare February 15, 2025 22:00
@manuel-rw manuel-rw force-pushed the feat/add-tile-border-radius branch 5 times, most recently from d35736b to 0d6d270 Compare February 18, 2025 20:05
@manuel-rw manuel-rw force-pushed the feat/add-tile-border-radius branch from 0d6d270 to 0a27b34 Compare February 18, 2025 20:06
Meierschlumpf
Meierschlumpf previously approved these changes Feb 18, 2025
Meierschlumpf
Meierschlumpf previously approved these changes Feb 18, 2025
@Meierschlumpf Meierschlumpf merged commit 7705bc4 into dev Feb 18, 2025
12 of 13 checks passed
@Meierschlumpf Meierschlumpf deleted the feat/add-tile-border-radius branch February 18, 2025 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants