Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add app ping url #2380

Merged
merged 2 commits into from
Feb 21, 2025
Merged

feat: add app ping url #2380

merged 2 commits into from
Feb 21, 2025

Conversation

manuel-rw
Copy link
Member

@manuel-rw manuel-rw commented Feb 20, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image

@manuel-rw manuel-rw linked an issue Feb 20, 2025 that may be closed by this pull request
@manuel-rw manuel-rw self-assigned this Feb 20, 2025
@manuel-rw manuel-rw added the enhancement New feature or request label Feb 20, 2025
Copy link

deepsource-io bot commented Feb 20, 2025

Here's the code health analysis summary for commits 9d54e93..f37e0b2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Feb 20, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.5% 8845 / 41137
🔵 Statements 21.5% 8845 / 41137
🔵 Functions 26.78% 346 / 1292
🔵 Branches 62.03% 1013 / 1633
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/api/src/router/app.ts 75.6% 81.25% 100% 75.6% 22-35, 51-55, 73-83, 112-114, 139-147
packages/db/schema/mysql.ts 100% 100% 100% 100%
packages/db/schema/sqlite.ts 100% 100% 100% 100%
packages/forms-collection/src/new-app/_form.tsx 0% 0% 0% 0% 1-115
packages/modals-collection/src/docker/add-docker-app-to-homarr.tsx 0% 0% 0% 0% 1-92
packages/old-import/src/import-apps.ts 0% 0% 0% 0% 1-160
packages/old-import/src/mappers/map-app.ts 9.09% 100% 0% 9.09% 8-16, 19-29
packages/validation/src/app.ts 100% 71.42% 100% 100%
packages/widgets/src/app/component.tsx 0% 0% 0% 0% 1-126
packages/widgets/src/bookmarks/add-button.tsx 30% 100% 0% 30% 22-30
Generated in workflow #5221 for commit f37e0b2 by the Vitest Coverage Report Action

@manuel-rw manuel-rw force-pushed the feat/add-app-ping-url branch 4 times, most recently from fbeb6c3 to a47e6c9 Compare February 20, 2025 22:15
@manuel-rw manuel-rw force-pushed the feat/add-app-ping-url branch from a47e6c9 to 546fad2 Compare February 20, 2025 22:16
@manuel-rw manuel-rw marked this pull request as ready for review February 20, 2025 22:21
@manuel-rw manuel-rw requested a review from a team as a code owner February 20, 2025 22:21
@Meierschlumpf
Copy link
Member

If you agree with my points and are able to fix them until todays release, you can merge this PR if you want. If you don't agree then we can discuss further after it and release it next week

@manuel-rw manuel-rw force-pushed the feat/add-app-ping-url branch from 827ed8a to b846065 Compare February 21, 2025 21:07
@manuel-rw manuel-rw force-pushed the feat/add-app-ping-url branch from b846065 to f37e0b2 Compare February 21, 2025 21:40
@manuel-rw manuel-rw merged commit fb467ac into dev Feb 21, 2025
13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: additional URL in apps for app pings
2 participants