Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(medias): svg files don't load in list #2381

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #2253

Before:
image

After:
image

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Feb 20, 2025
@Meierschlumpf Meierschlumpf self-assigned this Feb 20, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner February 20, 2025 21:50
Copy link

deepsource-io bot commented Feb 20, 2025

Here's the code health analysis summary for commits 311ae80..277b505. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.48% 8829 / 41094
🔵 Statements 21.48% 8829 / 41094
🔵 Functions 26.78% 346 / 1292
🔵 Branches 61.99% 1008 / 1626
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/manage/medias/page.tsx 0% 0% 0% 0% 1-157
Generated in workflow #5199 for commit 277b505 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit 52549a5 into dev Feb 20, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-media-svg-list branch February 20, 2025 21:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: SVG Files
2 participants