Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(import): autofix missing sizes of items with grid-algorithm #2522

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #2517

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Mar 6, 2025
@Meierschlumpf Meierschlumpf self-assigned this Mar 6, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner March 6, 2025 21:08
Copy link

deepsource-io bot commented Mar 6, 2025

Here's the code health analysis summary for commits 3403579..7038fba. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Mar 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.26% 9900 / 42554
🔵 Statements 23.26% 9900 / 42554
🔵 Functions 30.11% 415 / 1378
🔵 Branches 65.05% 1186 / 1823
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/old-import/src/move-widgets-and-apps-merge.ts 2.27% 100% 0% 2.27% 11-130, 133-206, 209-279, 282-302, 309-333
packages/old-import/src/import/collections/board-collection.ts 2.24% 100% 0% 2.24% 18-120
packages/old-import/src/mappers/map-column-count.ts 6.66% 100% 0% 6.66% 4-17
packages/old-import/src/prepare/prepare-items.ts 4.93% 100% 0% 4.93% 11-79, 82-89, 92-101
packages/old-schema/src/index.ts 100% 100% 100% 100%
packages/old-schema/src/tile.ts 82.75% 100% 50% 82.75% 65-74
Generated in workflow #5405 for commit 7038fba by the Vitest Coverage Report Action

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Import to 1.0 fails to find shape "md" for all app id's but my shapes are only lg. It crashes.
1 participant