-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add icons for Modbus Connect #6666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @dmatscheko 👋
Thanks for opening a pull request. The provided branding looks a bit different compared to the Modbus branding I've seen before and also seems to differ from the branding they are using on their website:
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi @frenck, 😊 Thank you so much for taking the time to review the logo for the Modbus Connect integration. I really appreciate your feedback! I intentionally designed the logo to be distinct from the original Modbus branding to avoid any potential design conflicts or infringements and to give this custom integration its own unique identity. My goal was to create a visual blend of both the Modbus and Home Assistant styles. For the design, I drew inspiration from the Modbus logo's use of multiple small balls around a central element, but I adapted it to align with the Home Assistant aesthetic. That’s why I included white balls, similar to the Home Assistant logo, arranged in a circular pattern reminiscent of the Modbus design. The central element (in Modbus orange) is meant to evoke the house from the Home Assistant logo, while the “M” is the only direct nod to the original Modbus branding. I also researched other custom Modbus integrations before and noticed that their logos differ significantly from the original (more than mine), so I felt this approach was appropriate. I hope this clarifies the thought process behind the design! I’m not a professional designer, so if you still think it needs adjustments to better fit the Home Assistant brand guidelines, I'd be happy to make changes. Best regards from Austria, Dave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we can't accept these, as they might misrepresent a brand, which we also don't want.
Please use the original Modbus branding.
Thanks! 👍
../Frenck
I changed the icon to the Modbus logo now. I drew the previous logo myself, that's why i did not want to delete it immediately. /David |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dmatscheko 👍
../Frenck
Proposed change
Add icons for the Home Assistant Integration Modbus Connect.
Modbus Connect is a custom integration that enables communication with Modbus devices via a Modbus TCP gateway. It uses a single YAML configuration file per device to define registers and coils, mapping them to Home Assistant entities like sensors, switches, numbers, and more. It supports both monitoring (read-only) and control (read/write) operations.
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)