Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add petkit smart devices #6683

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jezza34000
Copy link
Contributor

Proposed change

Added logo and icon for Petkit (smart devices) like Feeder, LitterBox, Foutain, Air Purifiers.

Type of change

  • Add a new logo or icon for a custom integration (custom component)
    • I've added a link to my custom integration repository in the PR description

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Jezza34000 👋

Thanks for opening a pull request. However, the provided icons look like application icons and not the branding the manufacturer is using otherwise.

Can you make sure you use their main branding instead?

Thanks 👍

../Frenck

@home-assistant
Copy link

home-assistant bot commented Mar 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 7, 2025 12:47
@Jezza34000
Copy link
Contributor Author

Hi @frenck

Thanks for your feedback! I understand your concern, but it looks like Petkit is in the process of changing its branding. The icons I provided are directly taken from the Play Store and App Store, which have been updated very recently (about a week ago). Given the timing, it's very likely that the manufacturer is rolling out a rebranding.

Let me know if you need any additional confirmation or if you'd like me to monitor further updates.

👍

@Jezza34000 Jezza34000 marked this pull request as ready for review March 7, 2025 13:11
@home-assistant home-assistant bot requested a review from frenck March 7, 2025 13:11
@frenck
Copy link
Member

frenck commented Mar 7, 2025

The icons I provided are directly taken from the Play Store and App Store, which have been updated very recently

Most brands use different styling in their application icons. We really don't want to use those for that reason.

../Frenck

@frenck frenck marked this pull request as draft March 7, 2025 19:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants