Add support for Ring Intercom (bypass #91600)

[shatteringlass]

Note to maintainers: this is simply a bypass to PR #91600 (whose author, @MartinPham has been inactive for several months) incorporating the required fixes as provided by seik@9728a5a. Hopefully this will get the ball rolling again.

Breaking change

Proposed change

The current Ring intergration is not supporting Ring Intercom devices (https://it-it.ring.com/products/intercom), as described here #82565. I've added support for it, introducing new sensors, and button to open door

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Ring Integration does not show Ring Intercom device/entities #82565
• This PR is related to issue:
• Link to documentation pull request: Add support for Ring Intercom home-assistant.io#27050

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hello @shatteringlass,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• 4347874bb0f1f309398e9201251c9a246fc26a92 - This commit has something that looks like an email address (ivanmartinga@gmail.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <email@address.com>"
     

     (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[home-assistant]

Hey there @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (ring) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ring can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign ring Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[sdb9696]

Hi @shatteringlass, AFAICT the ring_doorbell library does not yet support intercom devices. There is a PR open to add support but it is old and has not been merged. How are you testing this HA PR? Are you using a custom fork of the library?

I've recently been added as a maintainer on the ring_doorbell library. I'm happy to help getting this functionality into the library and then into HA but we would need to work on the ring_doorbell library first.

[shatteringlass]

Hello @sdb9696 , sorry for any confusion I may have caused. This PR is not containing any of my code, rather it is putting together the contributions of @MartinPham and @seik. To this day, I have been succesfully running https://github.com/MartinPham/ring-integration-modified and I think it is ready to be merged.

[sdb9696]

Hi @shatteringlass please see my comment on #91600 (comment). This PR will not work without changes to the dependant library. Also I'm not sure how you've pulled in seik's commit but it doesn't seem to have worked properly as it doesn't show any content and the bot is complaining above.

[shatteringlass]

Thanks for you clarification. I will close this PR for now and see if I can work in the direction you have highlighted.