Prevent trailing line feeds in translation values #126446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
small-pr
19 tasks
epenet
requested review from
allenporter,
a team,
tronikos,
ludeeus and
emontnemery
as code owners
epenet
commented
Sep 22, 2024
| @@ -12,7 +12,7 @@ | |||
| "description": "[%key:component::bluetooth::config::step::bluetooth_confirm::description%]" | |||
| }, | |||
| "reauth_confirm": { | |||
| "description": "The activation code is no longer valid, a new unused activation code is needed.\n\n" | |||
| "description": "The activation code is no longer valid, a new unused activation code is needed." | |||
There was a problem hiding this comment.
As with all other violations, the line feeds seem intentional - but I am unsure why.
There was a problem hiding this comment.
It doesn't seem valid. If we want blank lines after the description in the UI that should be handled by the frontend, consistently.
allenporter
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
I may have added this for the google ones (which were copied to the others) but i'm not seeing an immediate reason.
There doesn't appear to be extra whitespace in the rendered markdown in an existing production instance:
I have not tried it with this change, but assuming it looks the similar then this seems fine to me.
tronikos
approved these changes
Sep 22, 2024
MartinHjelmare
approved these changes
Sep 23, 2024
joostlek
approved these changes
Sep 23, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA
Follow-up to #126427
cc @MartinHjelmare, based on post-merge feedback in #126427 (comment)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: