Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't raise Overkiz user flow unique_id check #133471

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Dec 18, 2024

Proposed change

Some users face issues where the Config Flow raises an exception Flow aborted: already_in_progress when their gateway is also discovered via zeroconf.

Fixes #133283
Fixes #127986

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @vlebourl, @tetienne, @nyroDev, @Tronix117, @alexfp14, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@iMicknl iMicknl requested a review from Copilot December 18, 2024 10:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

homeassistant/components/overkiz/config_flow.py:79

  • The new behavior introduced by setting raise_on_progress=False should be covered by tests to ensure it works as expected and doesn't introduce regressions.
await self.async_set_unique_id(gateway_id, raise_on_progress=False)
@joostlek joostlek added this to the 2024.12.5 milestone Dec 18, 2024
@joostlek joostlek merged commit fa0e54e into home-assistant:dev Dec 18, 2024
30 checks passed
@iMicknl iMicknl deleted the overkiz/fix_config_flow_abort branch December 18, 2024 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
3 participants