-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make elevenlabs recoverable #134094
Make elevenlabs recoverable #134094
Conversation
Hey there @sorgfresser, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch! Tested locally and works as intended.
The coverage is not happy though. I'm happy to add a test
I PR'ed them in your repo joostlek#4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like init
isn't tested anyhow.
Co-authored-by: Simon <80467011+sorgfresser@users.noreply.github.com>
* Make elevenlabs recoverable * Add tests for entry setup * Use the same fixtures for setup and config flow * Update tests/components/elevenlabs/test_setup.py Co-authored-by: Simon <80467011+sorgfresser@users.noreply.github.com> --------- Co-authored-by: Simon Sorg <simon.sorg@student.hpi.de> Co-authored-by: G Johansson <goran.johansson@shiftit.se> Co-authored-by: Simon <80467011+sorgfresser@users.noreply.github.com>
* Make elevenlabs recoverable * Add tests for entry setup * Use the same fixtures for setup and config flow * Update tests/components/elevenlabs/test_setup.py Co-authored-by: Simon <80467011+sorgfresser@users.noreply.github.com> --------- Co-authored-by: Simon Sorg <simon.sorg@student.hpi.de> Co-authored-by: G Johansson <goran.johansson@shiftit.se> Co-authored-by: Simon <80467011+sorgfresser@users.noreply.github.com>
Proposed change
Make elevenlabs recoverable
So last night the power went out in my building, and it got restored an hour later. The main internet switch did not restore right away. This of course causes HA to still try to connect to the internet, but it can't resolve DNS.
After this, the integration did not reload anymore. This PR is making sure we catch this exception so we can retry again later
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: