Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve hassio backup create and restore parameter checks #134434

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

emontnemery
Copy link
Contributor

Proposed change

Improve hassio backup create and restore parameter checks:

  • It's not possible to create a backup with database but no home assistant settings
  • It's not possible to restore database from a backup which doesn't have database or not restore the database from a backup which has database

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 2, 2025

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery emontnemery force-pushed the hassio_backup_improve_checks branch from cb3eea0 to 76ed3ff Compare January 2, 2025 10:43
@emontnemery emontnemery added this to the 2025.1.0 milestone Jan 2, 2025
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now the PR LGTM is fine as it reflects Supervisor's capability.

if (
backup
and restore_homeassistant
and restore_database != backup.database_included
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this implements what you write here:

It's not possible to restore database from a backup which doesn't have database or not restore the database from a backup which has database

and from what I understand what Supervisor is capable of today, correct?

IMHO, not restoring the data should be possible, but there is the concern what if this is a downgrade of Home Assistant Core, and the (currently newer) database is not compatible? 🤔 The Core will complain on startup, so it is "safe", but the outcome might not be what the user expect (since he presumably wants to continue with the current database).

When no database is part of the backup, the user can already run into this situation, so we are a bit inconsistent in what we allow today 😢

@emontnemery emontnemery merged commit 876b342 into dev Jan 2, 2025
60 checks passed
@emontnemery emontnemery deleted the hassio_backup_improve_checks branch January 2, 2025 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants