Log cloud backup agent file list #134556
Merged
Log cloud backup agent file list #134556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
core
integration: cloud
small-pr
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
frenck
approved these changes
Jan 3, 2025
ludeeus
reviewed
Jan 3, 2025
| @@ -208,6 +210,7 @@ async def async_list_backups(self, **kwargs: Any) -> list[AgentBackup]: | |||
| """List backups.""" | |||
| try: | |||
| backups = await async_files_list(self._cloud, storage_type=_STORAGE_BACKUP) | |||
| _LOGGER.debug("Cloud backups: %s", backups) | |||
There was a problem hiding this comment.
This can/will become large and should be guarded so it's not sent to the logger unless debug is enabled for this logger.
There was a problem hiding this comment.
It is already? As in, this is lazy logged?
There was a problem hiding this comment.
So we can remove all of these (_LOGGER.isEnabledFor(logging.DEBUG)) then example.
cereal2nd
pushed a commit
to cereal2nd/home-assistant
that referenced
this pull request
Jan 4, 2025
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Log cloud backup agent file list
The change is aimed at making it possible to debug issues such as #134374
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: