Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mention case-sensitivity in tplink credentials prompt #134606

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Jan 4, 2025

Proposed change

There are several reports about an error "Server response doesn't match our challenge" coming from the upstream library, which simply points out that the credentials do not match.
It has been reported that this might be due to incorrect letter casing in the e-mail address, e.g., #133164 (comment) and python-kasa/python-kasa#1351 (comment) .

To make it clear that both email and password should be written as they were when the device was provisioned through the app, this PR adds a remark about the case-sensitivity of the credentials to the input dialogs.

Related upstream PRs documenting the behavior:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 4, 2025

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rytilahti rytilahti changed the title Mention case-sensitiveness in tplink credentials prompt Mention case-sensitivity in tplink credentials prompt Jan 4, 2025
@bdraco bdraco added this to the 2025.1.1 milestone Jan 4, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rytilahti 👍

Happy New Year 🥂

../Frenck

@frenck frenck merged commit 69241e4 into dev Jan 4, 2025
34 checks passed
@frenck frenck deleted the tplink/cred_input_desc branch January 4, 2025 10:12
cereal2nd pushed a commit to cereal2nd/home-assistant that referenced this pull request Jan 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants